Commit 5f4dee73 authored by Tong Tiangen's avatar Tong Tiangen Committed by Greg Kroah-Hartman
Browse files

usb: isp1760: Fix meaningless check in isp1763_run() 



Remove attribution to retval before check, which make it completely
meaningless, and does't check what it was supposed: the return
value of the timed function to set up configuration flag.

Fixes: 60d789f3 ("usb: isp1760: add support for isp1763")
Tested-by: default avatarRui Miguel Silva <rui.silva@linaro.org>
Reviewed-by: default avatarRui Miguel Silva <rui.silva@linaro.org>
Signed-off-by: default avatarTong Tiangen <tongtiangen@huawei.com>
Link: https://lore.kernel.org/r/20210611014055.68551-1-tongtiangen@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e90f9ceb

drivers/usb/isp1760/isp1760-hcd.c

+0 −1
Original line number Diff line number Diff line
@@ -1648,7 +1648,6 @@ static int isp1763_run(struct usb_hcd *hcd) 
	down_write(&ehci_cf_port_reset_rwsem);

	retval = isp1760_hcd_set_and_wait(hcd, FLAG_CF, 250 * 1000);

	up_write(&ehci_cf_port_reset_rwsem);

	retval = 0;

	if (retval)

		return retval;