Commit 5ec12f1c authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Herbert Xu
Browse files

crypto: engine - Make crypto_engine_exit() return void 



All callers ignore the return value, so simplify by not providing one.

Note that crypto_engine_exit() is typically called in a device driver's
remove path (or the error path in probe), where errors cannot be handled
anyhow.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 0eb85cb3

crypto/crypto_engine.c

+2 −6
Original line number Diff line number Diff line
@@ -552,20 +552,16 @@ EXPORT_SYMBOL_GPL(crypto_engine_alloc_init); 
/**

 * crypto_engine_exit - free the resources of hardware engine when exit

 * @engine: the hardware engine need to be freed

 *

 * Return 0 for success.

 */

int crypto_engine_exit(struct crypto_engine *engine)

void crypto_engine_exit(struct crypto_engine *engine)

{

	int ret;



	ret = crypto_engine_stop(engine);

	if (ret)

		return ret;

		return;



	kthread_destroy_worker(engine->kworker);



	return 0;

}

EXPORT_SYMBOL_GPL(crypto_engine_exit);

include/crypto/engine.h

+1 −1
Original line number Diff line number Diff line
@@ -78,7 +78,7 @@ struct crypto_engine *crypto_engine_alloc_init_and_set(struct device *dev, 
						       bool retry_support,

						       int (*cbk_do_batch)(struct crypto_engine *engine),

						       bool rt, int qlen);

int crypto_engine_exit(struct crypto_engine *engine);

void crypto_engine_exit(struct crypto_engine *engine);



int crypto_engine_register_aead(struct aead_engine_alg *alg);

void crypto_engine_unregister_aead(struct aead_engine_alg *alg);