Commit 5a2a961b authored by Miaohe Lin's avatar Miaohe Lin Committed by Paolo Bonzini
Browse files

KVM: fix memoryleak in kvm_init() 



When alloc_cpumask_var_node() fails for a certain cpu, there might be some
allocated cpumasks for percpu cpu_kick_mask. We should free these cpumasks
or memoryleak will occur.

Fixes: baff59cc ("KVM: Pre-allocate cpumasks for kvm_make_all_cpus_request_except()")
Signed-off-by: default avatarMiaohe Lin <linmiaohe@huawei.com>
Link: https://lore.kernel.org/r/20220823063414.59778-1-linmiaohe@huawei.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent d38ba8cc

virt/kvm/kvm_main.c

+2 −3
Original line number Diff line number Diff line
@@ -5881,7 +5881,7 @@ int kvm_init(void *opaque, unsigned vcpu_size, unsigned vcpu_align, 


	r = kvm_async_pf_init();

	if (r)

		goto out_free_5;

		goto out_free_4;



	kvm_chardev_ops.owner = module;
@@ -5905,10 +5905,9 @@ int kvm_init(void *opaque, unsigned vcpu_size, unsigned vcpu_align, 


out_unreg:

	kvm_async_pf_deinit();

out_free_5:

out_free_4:

	for_each_possible_cpu(cpu)

		free_cpumask_var(per_cpu(cpu_kick_mask, cpu));

out_free_4:

	kmem_cache_destroy(kvm_vcpu_cache);

out_free_3:

	unregister_reboot_notifier(&kvm_reboot_notifier);