Commit 574015a8 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: hptiop: Call scsi_done() directly 

Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-38-bvanassche@acm.org


Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 82f01edc

drivers/scsi/hptiop.c

+2 −5
Original line number Diff line number Diff line
@@ -769,7 +769,7 @@ static void hptiop_finish_scsi_req(struct hptiop_hba *hba, u32 tag, 


skip_resid:

	dprintk("scsi_done(%p)\n", scp);

	scp->scsi_done(scp);

	scsi_done(scp);

	free_req(hba, &hba->reqs[tag]);

}
@@ -1002,9 +1002,6 @@ static int hptiop_queuecommand_lck(struct scsi_cmnd *scp, 
	int sg_count = 0;

	struct hptiop_request *_req;



	BUG_ON(!done);

	scp->scsi_done = done;



	_req = get_req(hba);

	if (_req == NULL) {

		dprintk("hptiop_queuecmd : no free req\n");
@@ -1059,7 +1056,7 @@ static int hptiop_queuecommand_lck(struct scsi_cmnd *scp, 


cmd_done:

	dprintk("scsi_done(scp=%p)\n", scp);

	scp->scsi_done(scp);

	scsi_done(scp);

	return 0;

}