Commit 565138ac authored by Dan Carpenter's avatar Dan Carpenter Committed by Martin K. Petersen
Browse files

scsi: iscsi: Fix harmless double shift bug 

These flags are supposed to be bit numbers.  Right now they cause a double
shift bug where we use BIT(BIT(2)) instead of BIT(2).  Fortunately, the bit
numbers are small and it's done consistently so it does not cause an issue
at run time.

Link: https://lore.kernel.org/r/YmFyWHf8nrrx+SHa@kili


Fixes: 5bd85625 ("scsi: iscsi: Merge suspend fields")
Reviewed-by: default avatarMike Christie <michael.christie@oracle.com>
Reviewed-by: default avatarLee Duncan <lduncan@suse.com>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 95af09fa

include/scsi/libiscsi.h

+3 −3
Original line number Diff line number Diff line
@@ -54,9 +54,9 @@ enum { 
#define ISID_SIZE			6



/* Connection flags */

#define ISCSI_CONN_FLAG_SUSPEND_TX	BIT(0)

#define ISCSI_CONN_FLAG_SUSPEND_RX	BIT(1)

#define ISCSI_CONN_FLAG_BOUND		BIT(2)

#define ISCSI_CONN_FLAG_SUSPEND_TX	0

#define ISCSI_CONN_FLAG_SUSPEND_RX	1

#define ISCSI_CONN_FLAG_BOUND		2



#define ISCSI_ITT_MASK			0x1fff

#define ISCSI_TOTAL_CMDS_MAX		4096