Commit 55a42c31 authored by Dmitry Bogdanov's avatar Dmitry Bogdanov Committed by Martin K. Petersen
Browse files

scsi: usb: gadget: f_tcm: Remove default fabric ops callouts 



Remove callouts that are identical to the default implementations in TCM
Core.

Signed-off-by: default avatarDmitry Bogdanov <d.bogdanov@yadro.com>
Link: https://lore.kernel.org/r/20230313181110.20566-8-d.bogdanov@yadro.com


Acked-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 51550985

drivers/usb/gadget/function/f_tcm.c

+0 −31
Original line number Diff line number Diff line
@@ -1253,11 +1253,6 @@ static int usbg_check_true(struct se_portal_group *se_tpg) 
	return 1;

}



static int usbg_check_false(struct se_portal_group *se_tpg)

{

	return 0;

}



static char *usbg_get_fabric_wwn(struct se_portal_group *se_tpg)

{

	struct usbg_tpg *tpg = container_of(se_tpg,
@@ -1274,11 +1269,6 @@ static u16 usbg_get_tag(struct se_portal_group *se_tpg) 
	return tpg->tport_tpgt;

}



static u32 usbg_tpg_get_inst_index(struct se_portal_group *se_tpg)

{

	return 1;

}



static void usbg_release_cmd(struct se_cmd *se_cmd)

{

	struct usbg_cmd *cmd = container_of(se_cmd, struct usbg_cmd,
@@ -1289,20 +1279,6 @@ static void usbg_release_cmd(struct se_cmd *se_cmd) 
	target_free_tag(se_sess, se_cmd);

}



static u32 usbg_sess_get_index(struct se_session *se_sess)

{

	return 0;

}



static void usbg_set_default_node_attrs(struct se_node_acl *nacl)

{

}



static int usbg_get_cmd_state(struct se_cmd *se_cmd)

{

	return 0;

}



static void usbg_queue_tm_rsp(struct se_cmd *se_cmd)

{

}
@@ -1691,16 +1667,9 @@ static const struct target_core_fabric_ops usbg_ops = { 
	.tpg_get_wwn			= usbg_get_fabric_wwn,

	.tpg_get_tag			= usbg_get_tag,

	.tpg_check_demo_mode		= usbg_check_true,

	.tpg_check_demo_mode_cache	= usbg_check_false,

	.tpg_check_demo_mode_write_protect = usbg_check_false,

	.tpg_check_prod_mode_write_protect = usbg_check_false,

	.tpg_get_inst_index		= usbg_tpg_get_inst_index,

	.release_cmd			= usbg_release_cmd,

	.sess_get_index			= usbg_sess_get_index,

	.sess_get_initiator_sid		= NULL,

	.write_pending			= usbg_send_write_request,

	.set_default_node_attributes	= usbg_set_default_node_attrs,

	.get_cmd_state			= usbg_get_cmd_state,

	.queue_data_in			= usbg_send_read_response,

	.queue_status			= usbg_send_status_response,

	.queue_tm_rsp			= usbg_queue_tm_rsp,