Commit 5149fe2c authored by Oliver Neukum's avatar Oliver Neukum Committed by Jaroslav Kysela
Browse files

[ALSA] missing error check in usb sound driver 



usb_set_interface() can fail, even for altsetting 0

Signed-off-by: default avatarOliver Neukum <oneukum@suse.de>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarJaroslav Kysela <perex@suse.cz>
parent 15944806

sound/usb/usbaudio.c

+5 −1
Original line number Diff line number Diff line
@@ -1308,7 +1308,11 @@ static int set_format(struct snd_usb_substream *subs, struct audioformat *fmt) 


	/* close the old interface */

	if (subs->interface >= 0 && subs->interface != fmt->iface) {

		usb_set_interface(subs->dev, subs->interface, 0);

		if (usb_set_interface(subs->dev, subs->interface, 0) < 0) {

			snd_printk(KERN_ERR "%d:%d:%d: return to setting 0 failed\n",

				dev->devnum, fmt->iface, fmt->altsetting);

			return -EIO;

		}

		subs->interface = -1;

		subs->format = 0;

	}