Commit 5067ec64 authored by Jouni Högander's avatar Jouni Högander
Browse files

drm/i915/display: Move enable_sagv module parameter under display 



Move enable_sagv module parameter under display and change the parameter
permissions to non-writblase (0400)

v2: Change permissions to 0400

Signed-off-by: default avatarJouni Högander <jouni.hogander@intel.com>
Acked-by: default avatarJani Nikula <jani.nikula@intel.com>
Reviewed-by: default avatarLuca Coelho <luciano.coelho@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231024124109.384973-12-jouni.hogander@intel.com
parent 04da42b4

drivers/gpu/drm/i915/display/intel_display_params.c

+3 −0
Original line number Diff line number Diff line
@@ -50,6 +50,9 @@ intel_display_param_named_unsafe(enable_dc, int, 0400, 
intel_display_param_named_unsafe(enable_dpt, bool, 0400,

	"Enable display page table (DPT) (default: true)");



intel_display_param_named_unsafe(enable_sagv, bool, 0400,

	"Enable system agent voltage/frequency scaling (SAGV) (default: true)");



intel_display_param_named_unsafe(enable_fbc, int, 0400,

	"Enable frame buffer compression for power savings "

	"(default: -1 (use per-chip default))");

drivers/gpu/drm/i915/display/intel_display_params.h

+1 −0
Original line number Diff line number Diff line
@@ -30,6 +30,7 @@ struct drm_i915_private; 
	param(int, vbt_sdvo_panel_type, -1, 0400) \

	param(int, enable_dc, -1, 0400) \

	param(bool, enable_dpt, true, 0400) \

	param(bool, enable_sagv, true, 0600) \

	param(int, enable_fbc, -1, 0600) \

	param(int, enable_psr, -1, 0600) \

	param(bool, psr_safest_params, false, 0400) \

drivers/gpu/drm/i915/display/skl_watermark.c

+3 −2
Original line number Diff line number Diff line
@@ -412,7 +412,7 @@ static bool intel_crtc_can_enable_sagv(const struct intel_crtc_state *crtc_state 
	struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);

	struct drm_i915_private *i915 = to_i915(crtc->base.dev);



	if (!i915->params.enable_sagv)

	if (!i915->display.params.enable_sagv)

		return false;



	if (DISPLAY_VER(i915) >= 12)
@@ -3702,7 +3702,8 @@ static int intel_sagv_status_show(struct seq_file *m, void *unused) 
	};



	seq_printf(m, "SAGV available: %s\n", str_yes_no(intel_has_sagv(i915)));

	seq_printf(m, "SAGV modparam: %s\n", str_enabled_disabled(i915->params.enable_sagv));

	seq_printf(m, "SAGV modparam: %s\n",

		   str_enabled_disabled(i915->display.params.enable_sagv));

	seq_printf(m, "SAGV status: %s\n", sagv_status[i915->display.sagv.status]);

	seq_printf(m, "SAGV block time: %d usec\n", i915->display.sagv.block_time_us);

drivers/gpu/drm/i915/i915_params.c

+0 −3
Original line number Diff line number Diff line
@@ -82,9 +82,6 @@ i915_param_named_unsafe(enable_hangcheck, bool, 0400, 
	"WARNING: Disabling this can cause system wide hangs. "

	"(default: true)");



i915_param_named_unsafe(enable_sagv, bool, 0600,

	"Enable system agent voltage/frequency scaling (SAGV) (default: true)");



i915_param_named_unsafe(force_probe, charp, 0400,

	"Force probe options for specified supported devices. "

	"See CONFIG_DRM_I915_FORCE_PROBE for details.");

drivers/gpu/drm/i915/i915_params.h

+0 −1
Original line number Diff line number Diff line
@@ -47,7 +47,6 @@ struct drm_printer; 
 */

#define I915_PARAMS_FOR_EACH(param) \

	param(int, modeset, -1, 0400) \

	param(bool, enable_sagv, true, 0600) \

	param(int, disable_power_well, -1, 0400) \

	param(int, enable_ips, 1, 0600) \

	param(int, invert_brightness, 0, 0600) \