Commit 4f0922c8 authored by Dominic Braun's avatar Dominic Braun Committed by Greg Kroah-Hartman
Browse files

staging: vc04_services: Remove VCHIQ_SET_SERVICE_OPTION_T typedef 



Typedefing structs is not encouraged in the kernel.

Signed-off-by: default avatarDominic Braun <inf.braun@fau.de>
Signed-off-by: default avatarTobias Büttner <tobias.buettner@fau.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7926c328

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

+1 −1
Original line number Diff line number Diff line
@@ -1428,7 +1428,7 @@ vchiq_ioctl(struct file *file, unsigned int cmd, unsigned long arg) 
	} break;



	case VCHIQ_IOC_SET_SERVICE_OPTION: {

		VCHIQ_SET_SERVICE_OPTION_T args;

		struct vchiq_set_service_option args;



		if (copy_from_user(

			&args, (const void __user *)arg,

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h

+3 −3
Original line number Diff line number Diff line
@@ -88,11 +88,11 @@ struct vchiq_get_config { 
	struct vchiq_config __user *pconfig;

};



typedef struct {

struct vchiq_set_service_option {

	unsigned int handle;

	VCHIQ_SERVICE_OPTION_T option;

	int value;

} VCHIQ_SET_SERVICE_OPTION_T;

};



struct vchiq_dump_mem {

	void     *virt_addr;
@@ -121,7 +121,7 @@ struct vchiq_dump_mem { 
#define VCHIQ_IOC_USE_SERVICE          _IO(VCHIQ_IOC_MAGIC,   12)

#define VCHIQ_IOC_RELEASE_SERVICE      _IO(VCHIQ_IOC_MAGIC,   13)

#define VCHIQ_IOC_SET_SERVICE_OPTION \

	_IOW(VCHIQ_IOC_MAGIC,  14, VCHIQ_SET_SERVICE_OPTION_T)

	_IOW(VCHIQ_IOC_MAGIC,  14, struct vchiq_set_service_option)

#define VCHIQ_IOC_DUMP_PHYS_MEM \

	_IOW(VCHIQ_IOC_MAGIC,  15, struct vchiq_dump_mem)

#define VCHIQ_IOC_LIB_VERSION          _IO(VCHIQ_IOC_MAGIC,   16)