Commit 4efb6b2b authored by Omer Shpigelman's avatar Omer Shpigelman Committed by Oded Gabbay
Browse files

habanalabs: add hard reset timeout for PLDM 



Hard reset flow on PLDM might take more than 2 minutes.
Hence add a dedicated hard reset timeout of 6 minutes for PLDM.

Signed-off-by: default avatarOmer Shpigelman <oshpigelman@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 4b09901c

drivers/misc/habanalabs/common/device.c

+7 −2
Original line number Diff line number Diff line
@@ -1501,6 +1501,7 @@ int hl_device_init(struct hl_device *hdev, struct class *hclass) 
void hl_device_fini(struct hl_device *hdev)

{

	ktime_t timeout;

	u64 reset_sec;

	int i, rc;



	dev_info(hdev->dev, "Removing device\n");
@@ -1508,6 +1509,11 @@ void hl_device_fini(struct hl_device *hdev) 
	hdev->device_fini_pending = 1;

	flush_delayed_work(&hdev->device_reset_work.reset_work);



	if (hdev->pldm)

		reset_sec = HL_PLDM_HARD_RESET_MAX_TIMEOUT;

	else

		reset_sec = HL_HARD_RESET_MAX_TIMEOUT;



	/*

	 * This function is competing with the reset function, so try to

	 * take the reset atomic and if we are already in middle of reset,
@@ -1516,8 +1522,7 @@ void hl_device_fini(struct hl_device *hdev) 
	 * ports, the hard reset could take between 10-30 seconds

	 */



	timeout = ktime_add_us(ktime_get(),

				HL_HARD_RESET_MAX_TIMEOUT * 1000 * 1000);

	timeout = ktime_add_us(ktime_get(), reset_sec * 1000 * 1000);

	rc = atomic_cmpxchg(&hdev->in_reset, 0, 1);

	while (rc) {

		usleep_range(50, 200);

drivers/misc/habanalabs/common/habanalabs.h

+1 −0
Original line number Diff line number Diff line
@@ -48,6 +48,7 @@ 
#define HL_PENDING_RESET_LONG_SEC	60



#define HL_HARD_RESET_MAX_TIMEOUT	120

#define HL_PLDM_HARD_RESET_MAX_TIMEOUT	(HL_HARD_RESET_MAX_TIMEOUT * 3)



#define HL_DEVICE_TIMEOUT_USEC		1000000 /* 1 s */