Commit 4eb61e1a authored by Wei Yongjun's avatar Wei Yongjun Committed by Jonathan Cameron
Browse files

iio: adc: ti-ads131e08: Silence no spi_device_id warnings 



SPI devices use the spi_device_id for module autoloading even on
systems using device tree, after commit 5fa6863b ("spi: Check
we have a spi_device_id for each DT compatible"), kernel warns as
follows since the spi_device_id is missing:

SPI driver ads131e08 has no spi_device_id for ti,ads131e04
SPI driver ads131e08 has no spi_device_id for ti,ads131e06

Add spi_device_id entries to silence the warnings, and ensure driver
module autoloading works.

Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20220921163620.805879-2-weiyongjun@huaweicloud.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 55e00b87

drivers/iio/adc/ti-ads131e08.c

+11 −0
Original line number Diff line number Diff line
@@ -807,6 +807,8 @@ static int ads131e08_probe(struct spi_device *spi) 
	int ret;



	info = device_get_match_data(&spi->dev);

	if (!info)

		info = (void *)spi_get_device_id(spi)->driver_data;

	if (!info) {

		dev_err(&spi->dev, "failed to get match data\n");

		return -ENODEV;
@@ -926,12 +928,21 @@ static const struct of_device_id ads131e08_of_match[] = { 
};

MODULE_DEVICE_TABLE(of, ads131e08_of_match);



static const struct spi_device_id ads131e08_ids[] = {

	{ "ads131e04", (kernel_ulong_t)&ads131e08_info_tbl[ads131e04] },

	{ "ads131e06", (kernel_ulong_t)&ads131e08_info_tbl[ads131e06] },

	{ "ads131e08", (kernel_ulong_t)&ads131e08_info_tbl[ads131e08] },

	{}

};

MODULE_DEVICE_TABLE(spi, ads131e08_ids);



static struct spi_driver ads131e08_driver = {

	.driver = {

		.name = "ads131e08",

		.of_match_table = ads131e08_of_match,

	},

	.probe = ads131e08_probe,

	.id_table = ads131e08_ids,

};

module_spi_driver(ads131e08_driver);