Commit 4e670c8a authored by James Smart's avatar James Smart Committed by Martin K. Petersen
Browse files

scsi: lpfc: Keep NDLP reference until after freeing the IOCB after ELS handling 

In the routine that generically cleans up an ELS after completion, the NDLP
put is done prior to the freeing of the IOCB. The IOCB may reference the
NDLP.

Move the lpfc_nlp_put() after freeing the IOCB.

Link: https://lore.kernel.org/r/20210707184351.67872-8-jsmart2021@gmail.com


Co-developed-by: default avatarJustin Tee <justin.tee@broadcom.com>
Signed-off-by: default avatarJustin Tee <justin.tee@broadcom.com>
Signed-off-by: default avatarJames Smart <jsmart2021@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 21990d3d

drivers/scsi/lpfc/lpfc_sli.c

+7 −1
Original line number Diff line number Diff line
@@ -11623,6 +11623,7 @@ void 
lpfc_ignore_els_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,

		     struct lpfc_iocbq *rspiocb)

{

	struct lpfc_nodelist *ndlp = (struct lpfc_nodelist *) cmdiocb->context1;

	IOCB_t *irsp = &rspiocb->iocb;









	/* ELS cmd tag <ulpIoTag> completes */








@@ -11631,11 +11632,16 @@ lpfc_ignore_els_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,







			"x%x x%x x%x\n",









			irsp->ulpIoTag, irsp->ulpStatus,









			irsp->un.ulpWord[4], irsp->ulpTimeout);









	lpfc_nlp_put((struct lpfc_nodelist *)cmdiocb->context1);









	/*









	 * Deref the ndlp after free_iocb. sli_release_iocb will access the ndlp









	 * if exchange is busy.









	 */









	if (cmdiocb->iocb.ulpCommand == CMD_GEN_REQUEST64_CR)









		lpfc_ct_free_iocb(phba, cmdiocb);









	else









		lpfc_els_free_iocb(phba, cmdiocb);

















	lpfc_nlp_put(ndlp);









}

















/**