Commit 4e4e2ed2 authored by Giovanni Cabiddu's avatar Giovanni Cabiddu Committed by Herbert Xu
Browse files

crypto: qat - increase size of buffers 



Increase the size of the buffers used for composing the names used for
the transport debugfs entries and the vector name to avoid a potential
truncation.

This resolves the following errors when compiling the driver with W=1
and KCFLAGS=-Werror on GCC 12.3.1:

    drivers/crypto/intel/qat/qat_common/adf_transport_debug.c: In function ‘adf_ring_debugfs_add’:
    drivers/crypto/intel/qat/qat_common/adf_transport_debug.c:100:60: error: ‘snprintf’ output may be truncated before the last format character [-Werror=format-truncation=]
    drivers/crypto/intel/qat/qat_common/adf_isr.c: In function ‘adf_isr_resource_alloc’:
    drivers/crypto/intel/qat/qat_common/adf_isr.c:197:47: error: ‘%d’ directive output may be truncated writing between 1 and 11 bytes into a region of size between 0 and 5 [-Werror=format-truncation=]

Fixes: a672a9dc ("crypto: qat - Intel(R) QAT transport code")
Signed-off-by: default avatarGiovanni Cabiddu <giovanni.cabiddu@intel.com>
Reviewed-by: default avatarDamian Muszynski <damian.muszynski@intel.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent a8d3cdcc

drivers/crypto/intel/qat/qat_common/adf_accel_devices.h

+1 −1
Original line number Diff line number Diff line
@@ -29,7 +29,7 @@ 
#define ADF_PCI_MAX_BARS 3

#define ADF_DEVICE_NAME_LENGTH 32

#define ADF_ETR_MAX_RINGS_PER_BANK 16

#define ADF_MAX_MSIX_VECTOR_NAME 16

#define ADF_MAX_MSIX_VECTOR_NAME 48

#define ADF_DEVICE_NAME_PREFIX "qat_"



enum adf_accel_capabilities {

drivers/crypto/intel/qat/qat_common/adf_transport_debug.c

+2 −2
Original line number Diff line number Diff line
@@ -90,7 +90,7 @@ DEFINE_SEQ_ATTRIBUTE(adf_ring_debug); 
int adf_ring_debugfs_add(struct adf_etr_ring_data *ring, const char *name)

{

	struct adf_etr_ring_debug_entry *ring_debug;

	char entry_name[8];

	char entry_name[16];



	ring_debug = kzalloc(sizeof(*ring_debug), GFP_KERNEL);

	if (!ring_debug)
@@ -192,7 +192,7 @@ int adf_bank_debugfs_add(struct adf_etr_bank_data *bank) 
{

	struct adf_accel_dev *accel_dev = bank->accel_dev;

	struct dentry *parent = accel_dev->transport->debug;

	char name[8];

	char name[16];



	snprintf(name, sizeof(name), "bank_%02d", bank->bank_number);

	bank->bank_debug_dir = debugfs_create_dir(name, parent);