Commit 4de96230 authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915: Use fb->format->is_yuv for the g4x+ sprite RGB vs. YUV check 



g4x+ sprites have an extra cdclk limitation listed for RGB formats.
For some random reason I chose to use cpp>=4 as the check for that.
While that does actually work let's deobfuscate it by checking
for !is_yuv instead. I suspect is_yuv didn't exist way back when
I originally write the code.

Also drop the duplicate comment.

Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200206201204.31704-2-ville.syrjala@linux.intel.com


Acked-by: default avatarJani Nikula <jani.nikula@intel.com>
parent 23d3e379

drivers/gpu/drm/i915/display/intel_sprite.c

+2 −2
Original line number Diff line number Diff line
@@ -1639,8 +1639,8 @@ static int g4x_sprite_min_cdclk(const struct intel_crtc_state *crtc_state, 
	limit -= decimate;



	/* -10% for RGB */

	if (fb->format->cpp[0] >= 4)

		limit--; /* -10% for RGB */

	if (!fb->format->is_yuv)

		limit--;



	/*

	 * We should also do -10% if sprite scaling is enabled