Commit 4c452b5c authored by Srinivasan Shanmugam's avatar Srinivasan Shanmugam Committed by Alex Deucher
Browse files

drm/amdgpu: Fix missing comment for mb() in 'amdgpu_device_aper_access' 



This patch adds the missing code comment for memory barrier

WARNING: memory barrier without comment
+                       mb();

WARNING: memory barrier without comment
+                       mb();

Cc: Guchun Chen <guchun.chen@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Signed-off-by: default avatarSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: default avatarGuchun Chen <guchun.chen@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent c84f5123

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

+6 −0
Original line number Diff line number Diff line
@@ -305,10 +305,16 @@ size_t amdgpu_device_aper_access(struct amdgpu_device *adev, loff_t pos, 


		if (write) {

			memcpy_toio(addr, buf, count);

			/* Make sure HDP write cache flush happens without any reordering

			 * after the system memory contents are sent over PCIe device

			 */

			mb();

			amdgpu_device_flush_hdp(adev, NULL);

		} else {

			amdgpu_device_invalidate_hdp(adev, NULL);

			/* Make sure HDP read cache is invalidated before issuing a read

			 * to the PCIe device

			 */

			mb();

			memcpy_fromio(buf, addr, count);

		}