Commit 4a9dbd02 authored by Chengfeng Ye's avatar Chengfeng Ye Committed by Herbert Xu
Browse files

crypto: qce - fix uaf on qce_aead_register_one 



Pointer alg points to sub field of tmpl, it
is dereferenced after tmpl is freed. Fix
this by accessing alg before free tmpl.

Fixes: 9363efb4 ("crypto: qce - Add support for AEAD algorithms")
Signed-off-by: default avatarChengfeng Ye <cyeaa@connect.ust.hk>
Acked-by: default avatarThara Gopinath <thara.gopinath@linaro.org>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 574c833e

drivers/crypto/qce/aead.c

+1 −1
Original line number Diff line number Diff line
@@ -802,8 +802,8 @@ static int qce_aead_register_one(const struct qce_aead_def *def, struct qce_devi 


	ret = crypto_register_aead(alg);

	if (ret) {

		kfree(tmpl);

		dev_err(qce->dev, "%s registration failed\n", alg->base.cra_name);

		kfree(tmpl);

		return ret;

	}