Commit 4a29a072 authored by Lee Jones's avatar Lee Jones Committed by Greg Kroah-Hartman
Browse files

staging: r819xU_cmdpkt: Remove functionless method 'cmpk_handle_query_config_rx' 



Fixes the following W=1 kernel build warning(s):

 drivers/staging/rtl8192u/r819xU_cmdpkt.c: In function ‘cmpk_handle_query_config_rx’:
 drivers/staging/rtl8192u/r819xU_cmdpkt.c:274:24: warning: variable ‘rx_query_cfg’ set but not used [-Wunused-but-set-variable]

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Michael Straube <straube.linux@gmail.com>
Cc: linux-staging@lists.linux.dev
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20210414181129.1628598-7-lee.jones@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 803c63d9

drivers/staging/rtl8192u/r819xU_cmdpkt.c

+0 −41
Original line number Diff line number Diff line
@@ -249,46 +249,6 @@ static void cmpk_handle_interrupt_status(struct net_device *dev, u8 *pmsg) 
	DMESG("<---- cmpk_handle_interrupt_status()\n");

}



/*-----------------------------------------------------------------------------

 * Function:    cmpk_handle_query_config_rx()

 *

 * Overview:    The function is responsible for extract the message from

 *		firmware. It will contain dedicated info in

 *		ws-06-0063-rtl8190-command-packet-specification. Please

 *		refer to chapter "Beacon State Element".

 *

 * Input:       u8    *pmsg	-	Message Pointer of the command packet.

 *

 * Output:      NONE

 *

 * Return:      NONE

 *

 * Revised History:

 *  When		Who	Remark

 *  05/12/2008		amy	Create Version 0 porting from windows code.

 *

 *---------------------------------------------------------------------------

 */

static void cmpk_handle_query_config_rx(struct net_device *dev, u8 *pmsg)

{

	struct cmpk_query_cfg	rx_query_cfg;



	/* 1. Extract TX feedback info from RFD to temp structure buffer. */

	/* It seems that FW use big endian(MIPS) and DRV use little endian in

	 * windows OS. So we have to read the content byte by byte or transfer

	 * endian type before copy the message copy.

	 */

	rx_query_cfg.cfg_action		= (pmsg[4] & 0x80) >> 7;

	rx_query_cfg.cfg_type		= (pmsg[4] & 0x60) >> 5;

	rx_query_cfg.cfg_size		= (pmsg[4] & 0x18) >> 3;

	rx_query_cfg.cfg_page		= (pmsg[6] & 0x0F) >> 0;

	rx_query_cfg.cfg_offset		= pmsg[7];

	rx_query_cfg.value		= (pmsg[8]  << 24) | (pmsg[9]  << 16) |

					  (pmsg[10] <<  8) | (pmsg[11] <<  0);

	rx_query_cfg.mask		= (pmsg[12] << 24) | (pmsg[13] << 16) |

					  (pmsg[14] <<  8) | (pmsg[15] <<  0);

}



/*-----------------------------------------------------------------------------

 * Function:	cmpk_count_tx_status()

 *
@@ -514,7 +474,6 @@ u32 cmpk_message_handle_rx(struct net_device *dev, 
			break;



		case BOTH_QUERY_CONFIG:

			cmpk_handle_query_config_rx(dev, pcmd_buff);

			cmd_length = CMPK_BOTH_QUERY_CONFIG_SIZE;

			break;