Commit 49e50aad authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Lee Jones
Browse files

leds: core: Refactor led_update_brightness() to use standard pattern 



The standard conditional pattern is to check for errors first and
bail out if any. Refactor led_update_brightness() accordingly.

While at it, drop unneeded assignment and return 0 unconditionally
on success.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: default avatarDenis Osterland-Heim <denis.osterland@diehl.com>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20231016153051.1409074-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent 78cbcfd8

drivers/leds/led-core.c

+6 −6
Original line number Diff line number Diff line
@@ -364,17 +364,17 @@ EXPORT_SYMBOL_GPL(led_set_brightness_sync); 


int led_update_brightness(struct led_classdev *led_cdev)

{

	int ret = 0;

	int ret;



	if (led_cdev->brightness_get) {

		ret = led_cdev->brightness_get(led_cdev);

		if (ret >= 0) {

		if (ret < 0)

			return ret;



		led_cdev->brightness = ret;

			return 0;

		}

	}



	return ret;

	return 0;

}

EXPORT_SYMBOL_GPL(led_update_brightness);