Commit 486b10a2 authored by Vinod Koul's avatar Vinod Koul
Browse files

dmaengine: k3dma: explicitly freeup irq 



dmaengine device should explicitly call devm_free_irq() when using
devm_request_irq().

The irq is still ON when devices remove is executed and irq should be
quiesced before remove is completed.

Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
Acked-by: default avatarZhangfei Gao <zhangfei.gao@linaro.org>
parent 5bb9dbb5

drivers/dma/k3dma.c

+5 −0
Original line number Diff line number Diff line
@@ -102,6 +102,7 @@ struct k3_dma_dev { 
	struct clk		*clk;

	u32			dma_channels;

	u32			dma_requests;

	unsigned int		irq;

};



#define to_k3_dma(dmadev) container_of(dmadev, struct k3_dma_dev, slave)
@@ -703,6 +704,8 @@ static int k3_dma_probe(struct platform_device *op) 
	if (ret)

		return ret;



	d->irq = irq;



	/* init phy channel */

	d->phy = devm_kzalloc(&op->dev,

		d->dma_channels * sizeof(struct k3_dma_phy), GFP_KERNEL);
@@ -785,6 +788,8 @@ static int k3_dma_remove(struct platform_device *op) 
	dma_async_device_unregister(&d->slave);

	of_dma_controller_free((&op->dev)->of_node);



	devm_free_irq(&op->dev, d->irq, d);



	list_for_each_entry_safe(c, cn, &d->slave.channels, vc.chan.device_node) {

		list_del(&c->vc.chan.device_node);

		tasklet_kill(&c->vc.task);