Commit 47013c58 authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Damien Le Moal
Browse files

ata: sata_nv: drop pointless VPRINTK() calls and convert remaining ones 



Quite some information from the VPRINTK() is already covered by
tracepoints, so remove the pointless calls and convert the remaining
ones to structured logging.

Signed-off-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
parent 23b87b9f

drivers/ata/sata_nv.c

+14 −24
Original line number Diff line number Diff line
@@ -809,7 +809,7 @@ static int nv_adma_check_cpb(struct ata_port *ap, int cpb_num, int force_err) 
	struct nv_adma_port_priv *pp = ap->private_data;

	u8 flags = pp->cpb[cpb_num].resp_flags;



	VPRINTK("CPB %d, flags=0x%x\n", cpb_num, flags);

	ata_port_dbg(ap, "CPB %d, flags=0x%x\n", cpb_num, flags);



	if (unlikely((force_err ||

		     flags & (NV_CPB_RESP_ATA_ERR |
@@ -1101,8 +1101,6 @@ static int nv_adma_port_start(struct ata_port *ap) 
	struct pci_dev *pdev = to_pci_dev(dev);

	u16 tmp;



	VPRINTK("ENTER\n");



	/*

	 * Ensure DMA mask is set to 32-bit before allocating legacy PRD and

	 * pad buffers.
@@ -1191,7 +1189,6 @@ static void nv_adma_port_stop(struct ata_port *ap) 
	struct nv_adma_port_priv *pp = ap->private_data;

	void __iomem *mmio = pp->ctl_block;



	VPRINTK("ENTER\n");

	writew(0, mmio + NV_ADMA_CTL);

}
@@ -1253,8 +1250,6 @@ static void nv_adma_setup_port(struct ata_port *ap) 
	void __iomem *mmio = ap->host->iomap[NV_MMIO_BAR];

	struct ata_ioports *ioport = &ap->ioaddr;



	VPRINTK("ENTER\n");



	mmio += NV_ADMA_PORT + ap->port_no * NV_ADMA_PORT_SIZE;



	ioport->cmd_addr	= mmio;
@@ -1375,8 +1370,6 @@ static enum ata_completion_errors nv_adma_qc_prep(struct ata_queued_cmd *qc) 
	if (qc->tf.protocol == ATA_PROT_NCQ)

		ctl_flags |= NV_CPB_CTL_QUEUE | NV_CPB_CTL_FPDMA;



	VPRINTK("qc->flags = 0x%lx\n", qc->flags);



	nv_adma_tf_to_cpb(&qc->tf, cpb->tf);



	if (qc->flags & ATA_QCFLAG_DMAMAP) {
@@ -1401,8 +1394,6 @@ static unsigned int nv_adma_qc_issue(struct ata_queued_cmd *qc) 
	void __iomem *mmio = pp->ctl_block;

	int curr_ncq = (qc->tf.protocol == ATA_PROT_NCQ);



	VPRINTK("ENTER\n");



	/* We can't handle result taskfile with NCQ commands, since

	   retrieving the taskfile switches us out of ADMA mode and would abort

	   existing commands. */
@@ -1414,7 +1405,6 @@ static unsigned int nv_adma_qc_issue(struct ata_queued_cmd *qc) 


	if (nv_adma_use_reg_mode(qc)) {

		/* use ATA register mode */

		VPRINTK("using ATA register mode: 0x%lx\n", qc->flags);

		BUG_ON(!(pp->flags & NV_ADMA_ATAPI_SETUP_COMPLETE) &&

			(qc->flags & ATA_QCFLAG_DMAMAP));

		nv_adma_register_mode(qc->ap);
@@ -1866,12 +1856,12 @@ static void nv_swncq_host_init(struct ata_host *host) 


	/* enable swncq */

	tmp = readl(mmio + NV_CTL_MCP55);

	VPRINTK("HOST_CTL:0x%X\n", tmp);

	dev_dbg(&pdev->dev, "HOST_CTL:0x%X\n", tmp);

	writel(tmp | NV_CTL_PRI_SWNCQ | NV_CTL_SEC_SWNCQ, mmio + NV_CTL_MCP55);



	/* enable irq intr */

	tmp = readl(mmio + NV_INT_ENABLE_MCP55);

	VPRINTK("HOST_ENABLE:0x%X\n", tmp);

	dev_dbg(&pdev->dev, "HOST_ENABLE:0x%X\n", tmp);

	writel(tmp | 0x00fd00fd, mmio + NV_INT_ENABLE_MCP55);



	/*  clear port irq */
@@ -2101,7 +2091,7 @@ static int nv_swncq_sdbfis(struct ata_port *ap) 
	ata_qc_complete_multiple(ap, ata_qc_get_active(ap) ^ done_mask);



	if (!ap->qc_active) {

		DPRINTK("over\n");

		ata_port_dbg(ap, "over\n");

		nv_swncq_pp_reinit(ap);

		return 0;

	}
@@ -2116,10 +2106,10 @@ static int nv_swncq_sdbfis(struct ata_port *ap) 
		 */

		lack_dhfis = 1;



	DPRINTK("id 0x%x QC: qc_active 0x%llx,"

	ata_port_dbg(ap, "QC: qc_active 0x%llx,"

		     "SWNCQ:qc_active 0x%X defer_bits %X "

		     "dhfis 0x%X dmafis 0x%X last_issue_tag %x\n",

		ap->print_id, ap->qc_active, pp->qc_active,

		     ap->qc_active, pp->qc_active,

		     pp->defer_queue.defer_bits, pp->dhfis_bits,

		     pp->dmafis_bits, pp->last_issue_tag);
@@ -2161,7 +2151,7 @@ static void nv_swncq_dmafis(struct ata_port *ap) 
	__ata_bmdma_stop(ap);

	tag = nv_swncq_tag(ap);



	DPRINTK("dma setup tag 0x%x\n", tag);

	ata_port_dbg(ap, "dma setup tag 0x%x\n", tag);

	qc = ata_qc_from_tag(ap, tag);



	if (unlikely(!qc))
@@ -2229,9 +2219,9 @@ static void nv_swncq_host_interrupt(struct ata_port *ap, u16 fis) 


	if (fis & NV_SWNCQ_IRQ_SDBFIS) {

		pp->ncq_flags |= ncq_saw_sdb;

		DPRINTK("id 0x%x SWNCQ: qc_active 0x%X "

		ata_port_dbg(ap, "SWNCQ: qc_active 0x%X "

			"dhfis 0x%X dmafis 0x%X sactive 0x%X\n",

			ap->print_id, pp->qc_active, pp->dhfis_bits,

			pp->qc_active, pp->dhfis_bits,

			pp->dmafis_bits, readl(pp->sactive_block));

		if (nv_swncq_sdbfis(ap) < 0)

			goto irq_error;
@@ -2257,7 +2247,7 @@ static void nv_swncq_host_interrupt(struct ata_port *ap, u16 fis) 
				goto irq_exit;



			if (pp->defer_queue.defer_bits) {

				DPRINTK("send next command\n");

				ata_port_dbg(ap, "send next command\n");

				qc = nv_swncq_qc_from_dq(ap);

				nv_swncq_issue_atacmd(ap, qc);

			}