Commit 46b87976 authored by Bernd Edlinger's avatar Bernd Edlinger Committed by Kalle Valo
Browse files

rtl8723ae: Take the FW LPS mode handling out 



This appears to trigger a firmware bug and causes severe
problems with rtl8723ae PCI devices.

When the power save mode is activated for longer periods
of time the firmware stops to receive any packets.

This problem was exposed by commit 873ffe15 ("rtlwifi:
Fix logic error in enter/exit power-save mode").

Previously the power save mode was only active rarely and
only for a short time so that the problem was not noticeable.

Signed-off-by: default avatarBernd Edlinger <bernd.edlinger@hotmail.de>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 43425683

drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c

+4 −4
Original line number Diff line number Diff line
@@ -266,8 +266,8 @@ static struct rtl_hal_ops rtl8723e_hal_ops = { 
static struct rtl_mod_params rtl8723e_mod_params = {

	.sw_crypto = false,

	.inactiveps = true,

	.swctrl_lps = false,

	.fwctrl_lps = true,

	.swctrl_lps = true,

	.fwctrl_lps = false,

	.aspm_support = 1,

	.debug_level = 0,

	.debug_mask = 0,
@@ -395,8 +395,8 @@ module_param_named(disable_watchdog, rtl8723e_mod_params.disable_watchdog, 
		   bool, 0444);

MODULE_PARM_DESC(swenc, "Set to 1 for software crypto (default 0)\n");

MODULE_PARM_DESC(ips, "Set to 0 to not use link power save (default 1)\n");

MODULE_PARM_DESC(swlps, "Set to 1 to use SW control power save (default 0)\n");

MODULE_PARM_DESC(fwlps, "Set to 1 to use FW control power save (default 1)\n");

MODULE_PARM_DESC(swlps, "Set to 1 to use SW control power save (default 1)\n");

MODULE_PARM_DESC(fwlps, "Set to 1 to use FW control power save (default 0)\n");

MODULE_PARM_DESC(msi, "Set to 1 to use MSI interrupts mode (default 0)\n");

MODULE_PARM_DESC(aspm, "Set to 1 to enable ASPM (default 1)\n");

MODULE_PARM_DESC(debug_level, "Set debug level (0-5) (default 0)");