Commit 436cce00 authored Nov 06, 2020 by Leo Yan Committed by Arnaldo Carvalho de Melo Nov 11, 2020

perf mem: Only initialize memory event for recording



It's needless to initialize memory events for reporting, this patch
moves memory event initialization for only recording.  Furthermore,
the change allows to parse perf data on cross platforms, e.g. perf
tool can report result properly even the machine doesn't support
the memory events.

Signed-off-by: Leo Yan <leo.yan@linaro.org>
Acked-by: Ian Rogers <irogers@google.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Link: https://lore.kernel.org/r/20201106094853.21082-6-leo.yan@linaro.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 8b8173b4

tools/perf/builtin-mem.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -77,6 +77,11 @@ static int __cmd_record(int argc, const char *argv, struct perf_mem mem)
		OPT_END()
		};

		if (perf_mem_events__init()) {
		pr_err("failed: memory events not supported\n");
		return -1;
		}

		argc = parse_options(argc, argv, options, record_mem_usage,
		PARSE_OPT_KEEP_UNKNOWN);

		@@ -441,11 +446,6 @@ int cmd_mem(int argc, const char **argv)
		NULL
		};

		if (perf_mem_events__init()) {
		pr_err("failed: memory events not supported\n");
		return -1;
		}

		argc = parse_options_subcommand(argc, argv, mem_options, mem_subcommands,
		mem_usage, PARSE_OPT_KEEP_UNKNOWN);