Commit 42daecfc authored by Nirmoy Das's avatar Nirmoy Das Committed by Alex Deucher
Browse files

drm/amdgpu: remove AMDGPU_GEM_CREATE_SHADOW flag 



Remove unused AMDGPU_GEM_CREATE_SHADOW flag.
Userspace is never allowed to use this.

Signed-off-by: default avatarNirmoy Das <nirmoy.das@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent cd2454d6

drivers/gpu/drm/amd/amdgpu/amdgpu_object.c

+1 −4
Original line number Diff line number Diff line
@@ -649,8 +649,7 @@ int amdgpu_bo_create_shadow(struct amdgpu_device *adev, 
	memset(&bp, 0, sizeof(bp));

	bp.size = size;

	bp.domain = AMDGPU_GEM_DOMAIN_GTT;

	bp.flags = AMDGPU_GEM_CREATE_CPU_GTT_USWC |

		AMDGPU_GEM_CREATE_SHADOW;

	bp.flags = AMDGPU_GEM_CREATE_CPU_GTT_USWC;

	bp.type = ttm_bo_type_kernel;

	bp.resv = bo->tbo.base.resv;

	bp.bo_ptr_size = sizeof(struct amdgpu_bo);
@@ -685,7 +684,6 @@ int amdgpu_bo_create_user(struct amdgpu_device *adev, 
	struct amdgpu_bo *bo_ptr;

	int r;



	bp->flags = bp->flags & ~AMDGPU_GEM_CREATE_SHADOW;

	bp->bo_ptr_size = sizeof(struct amdgpu_bo_user);

	r = amdgpu_bo_create(adev, bp, &bo_ptr);

	if (r)
@@ -1559,7 +1557,6 @@ u64 amdgpu_bo_print_info(int id, struct amdgpu_bo *bo, struct seq_file *m) 
	amdgpu_bo_print_flag(m, bo, NO_CPU_ACCESS);

	amdgpu_bo_print_flag(m, bo, CPU_GTT_USWC);

	amdgpu_bo_print_flag(m, bo, VRAM_CLEARED);

	amdgpu_bo_print_flag(m, bo, SHADOW);

	amdgpu_bo_print_flag(m, bo, VRAM_CONTIGUOUS);

	amdgpu_bo_print_flag(m, bo, VM_ALWAYS_VALID);

	amdgpu_bo_print_flag(m, bo, EXPLICIT_SYNC);

include/uapi/drm/amdgpu_drm.h

+0 −2
Original line number Diff line number Diff line
@@ -116,8 +116,6 @@ extern "C" { 
#define AMDGPU_GEM_CREATE_CPU_GTT_USWC		(1 << 2)

/* Flag that the memory should be in VRAM and cleared */

#define AMDGPU_GEM_CREATE_VRAM_CLEARED		(1 << 3)

/* Flag that create shadow bo(GTT) while allocating vram bo */

#define AMDGPU_GEM_CREATE_SHADOW		(1 << 4)

/* Flag that allocating the BO should use linear VRAM */

#define AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS	(1 << 5)

/* Flag that BO is always valid in this VM */