Commit 425562be authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev/atafb: Initialize fb_ops to fbdev I/O-memory helpers 



Initialize the instance of struct fb_ops with fbdev initializer
macros for framebuffers in I/O address space. Set the read/write,
draw and mmap callbacks to the correct implementation and avoid
implicit defaults. Also select the necessary I/O helpers in Kconfig.

Fbdev drivers sometimes rely on the callbacks being NULL for a
default implementation to be invoked; hence requiring the I/O
helpers to be built in any case. Setting all callbacks in all
drivers explicitly will allow to make the I/O helpers optional.
This benefits systems that do not use these functions.

No functional changes.

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230927074722.6197-7-tzimmermann@suse.de
parent 7421a630

drivers/video/fbdev/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -289,6 +289,7 @@ config FB_ATARI 
	select FB_CFB_FILLRECT

	select FB_CFB_COPYAREA

	select FB_CFB_IMAGEBLIT

	select FB_IOMEM_FOPS

	help

	  This is the frame buffer device driver for the builtin graphics

	  chipset found in Ataris.

drivers/video/fbdev/atafb.c

+2 −0
Original line number Diff line number Diff line
@@ -2665,6 +2665,7 @@ static int atafb_set_par(struct fb_info *info) 


static struct fb_ops atafb_ops = {

	.owner =	THIS_MODULE,

	__FB_DEFAULT_IOMEM_OPS_RDWR,

	.fb_check_var	= atafb_check_var,

	.fb_set_par	= atafb_set_par,

	.fb_blank =	atafb_blank,
@@ -2673,6 +2674,7 @@ static struct fb_ops atafb_ops = { 
	.fb_copyarea	= atafb_copyarea,

	.fb_imageblit	= atafb_imageblit,

	.fb_ioctl =	atafb_ioctl,

	__FB_DEFAULT_IOMEM_OPS_MMAP,

};



static void check_default_par(int detected_mode)