Commit 405698ca authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Thomas Gleixner
Browse files

atm: eni: Use tasklet_disable_in_atomic() in the send() callback 



The atmdev_ops::send callback which calls tasklet_disable() is invoked with
bottom halfs disabled from net_device_ops::ndo_start_xmit(). All other
invocations of tasklet_disable() in this driver happen in preemptible
context.

Change the send() call to use tasklet_disable_in_atomic() which allows
tasklet_disable() to be made sleepable once the remaining atomic context
usage sites are cleaned up.

Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20210309084242.415583839@linutronix.de
parent 3250aa8a

drivers/atm/eni.c

+1 −1
Original line number Diff line number Diff line
@@ -2054,7 +2054,7 @@ static int eni_send(struct atm_vcc *vcc,struct sk_buff *skb) 
	}

	submitted++;

	ATM_SKB(skb)->vcc = vcc;

	tasklet_disable(&ENI_DEV(vcc->dev)->task);

	tasklet_disable_in_atomic(&ENI_DEV(vcc->dev)->task);

	res = do_tx(skb);

	tasklet_enable(&ENI_DEV(vcc->dev)->task);

	if (res == enq_ok) return 0;