Commit 3f3f5c7f authored by Javier Martin's avatar Javier Martin Committed by Mauro Carvalho Chehab
Browse files

[media] media: coda: Fix H.264 header alignment 



Length of H.264 headers is variable and thus it might not be
aligned for the coda to append the encoded frame. This causes
the first frame to overwrite part of the H.264 PPS.
In order to solve that, a filler NAL must be added between
the headers and the first frame to preserve alignment.

[mchehab@redhat.com: Fix a few CodingStyle issues]
Signed-off-by: default avatarJavier Martin <javier.martin@vista-silicon.com>

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent bbe2a1d3

drivers/media/platform/coda.c

+35 −1
Original line number Diff line number Diff line
@@ -178,6 +178,9 @@ struct coda_ctx { 
	int				idx;

};



static u8 coda_filler_nal[] = { 0x00, 0x00, 0x00, 0x01, 0x0c,

				 0xff, 0xff, 0xff, 0xff, 0xff};



static inline void coda_write(struct coda_dev *dev, u32 data, u32 reg)

{

	v4l2_dbg(1, coda_debug, &dev->v4l2_dev,
@@ -944,6 +947,29 @@ static int coda_alloc_framebuffers(struct coda_ctx *ctx, struct coda_q_data *q_d 
	return 0;

}



static int coda_h264_padding(int size, char *p)

{

	int size_align = size & ~0x3;

	int filler_size = ARRAY_SIZE(coda_filler_nal);

	int nal_size;

	int diff;



	diff = size - size_align;

	if (diff == 0)

		return 0;



	nal_size = filler_size + 2 - diff;

	if (nal_size > filler_size)

		nal_size -= 4;



	memcpy(p, coda_filler_nal, nal_size);



	/* Add rbsp stop bit and trailing at the end */

	*(p + nal_size - 1) = 0x80;



	return nal_size;

}



static int coda_start_streaming(struct vb2_queue *q, unsigned int count)

{

	struct coda_ctx *ctx = vb2_get_drv_priv(q);
@@ -1171,7 +1197,15 @@ static int coda_start_streaming(struct vb2_queue *q, unsigned int count) 
				coda_read(dev, CODA_CMD_ENC_HEADER_BB_START);

		memcpy(&ctx->vpu_header[1][0], vb2_plane_vaddr(buf, 0),

		       ctx->vpu_header_size[1]);

		ctx->vpu_header_size[2] = 0;

		/*

		 * Length of H.264 headers is variable and thus it might not be

		 * aligned for the coda to append the encoded frame. In that is

		 * the case a filler NAL must be added to header 2.

		 */

		ctx->vpu_header_size[2] = coda_h264_padding(

					(ctx->vpu_header_size[0] +

					 ctx->vpu_header_size[1]),

					 ctx->vpu_header[2]);

		break;

	case V4L2_PIX_FMT_MPEG4:

		/*