Commit 3a5e6502 authored by Jakob Koschel's avatar Jakob Koschel Committed by Greg Kroah-Hartman
Browse files

char: misc: remove usage of list iterator past the loop body 

In preparation to limit the scope of the list iterator to the list
traversal loop, use a dedicated pointer pointing to the found element [1].

Link: https://lore.kernel.org/all/YhdfEIwI4EdtHdym@kroah.com/


Signed-off-by: default avatarJakob Koschel <jakobkoschel@gmail.com>
Link: https://lore.kernel.org/r/20220319201454.2511733-1-jakobkoschel@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a8a570c6

drivers/char/misc.c

+13 −11
Original line number Diff line number Diff line
@@ -100,30 +100,32 @@ static const struct seq_operations misc_seq_ops = { 
static int misc_open(struct inode *inode, struct file *file)

{

	int minor = iminor(inode);

	struct miscdevice *c;

	struct miscdevice *c = NULL, *iter;

	int err = -ENODEV;

	const struct file_operations *new_fops = NULL;



	mutex_lock(&misc_mtx);



	list_for_each_entry(c, &misc_list, list) {

		if (c->minor == minor) {

			new_fops = fops_get(c->fops);

	list_for_each_entry(iter, &misc_list, list) {

		if (iter->minor != minor)

			continue;

		c = iter;

		new_fops = fops_get(iter->fops);

		break;

	}

	}



	if (!new_fops) {

		mutex_unlock(&misc_mtx);

		request_module("char-major-%d-%d", MISC_MAJOR, minor);

		mutex_lock(&misc_mtx);



		list_for_each_entry(c, &misc_list, list) {

			if (c->minor == minor) {

				new_fops = fops_get(c->fops);

		list_for_each_entry(iter, &misc_list, list) {

			if (iter->minor != minor)

				continue;

			c = iter;

			new_fops = fops_get(iter->fops);

			break;

		}

		}

		if (!new_fops)

			goto fail;

	}