staging: fbtft: Modify block comments based on kernel coding style (3a334ea5) · Commits · github.com / kvm-riscv / linux

drivers/staging/fbtft/fb_ili9163.c

+35 −34

Original line number	Diff line number	Diff line
		@@ -39,11 +39,11 @@
		#endif

		/* ILI9163C commands */
		#define CMD_FRMCTR1 0xB1 /* Frame Rate Control
		(In normal mode/Full colors) */
		#define CMD_FRMCTR1 0xB1 /* Frame Rate Control */
		/* (In normal mode/Full colors) */
		#define CMD_FRMCTR2 0xB2 /* Frame Rate Control (In Idle mode/8-colors) */
		#define CMD_FRMCTR3 0xB3 /* Frame Rate Control
		(In Partial mode/full colors) */
		#define CMD_FRMCTR3 0xB3 /* Frame Rate Control */
		/* (In Partial mode/full colors) */
		#define CMD_DINVCTR 0xB4 /* Display Inversion Control */
		#define CMD_RGBBLK 0xB5 /* RGB Interface Blanking Porch setting */
		#define CMD_DFUNCTR 0xB6 /* Display Function set 5 */
		@@ -63,16 +63,17 @@
		#define CMD_GAMRSEL 0xF2 /* GAM_R_SEL */

		/*
		This display:
		http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-Color-TFT-LCD-Display-Module-/271422122271
		This particular display has a design error! The controller has 3 pins to
		configure to constrain the memory and resolution to a fixed dimension (in
		that case 128x128) but they leaved those pins configured for 128x160 so
		there was several pixel memory addressing problems.
		I solved by setup several parameters that dinamically fix the resolution as
		needit so below the parameters for this display. If you have a strain or a
		correct display (can happen with chinese) you can copy those parameters and
		create setup for different displays.
		* This display:
		* http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-
		* Color-TFT-LCD-Display-Module-/271422122271
		* This particular display has a design error! The controller has 3 pins to
		* configure to constrain the memory and resolution to a fixed dimension (in
		* that case 128x128) but they leaved those pins configured for 128x160 so
		* there was several pixel memory addressing problems.
		* I solved by setup several parameters that dinamically fix the resolution as
		* needit so below the parameters for this display. If you have a strain or a
		* correct display (can happen with chinese) you can copy those parameters and
		* create setup for different displays.
		*/

		#ifdef RED
		@@ -153,24 +154,24 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys,
		}

		/*
		7) MY: 1(bottom to top), 0(top to bottom) Row Address Order
		6) MX: 1(R to L), 0(L to R) Column Address Order
		5) MV: 1(Exchanged), 0(normal) Row/Column exchange
		4) ML: 1(bottom to top), 0(top to bottom) Vertical Refresh Order
		3) RGB: 1(BGR), 0(RGB) Color Space
		2) MH: 1(R to L), 0(L to R) Horizontal Refresh Order
		1)
		0)

		MY, MX, MV, ML,RGB, MH, D1, D0
		0 \| 0 \| 0 \| 0 \| 1 \| 0 \| 0 \| 0 //normal
		1 \| 0 \| 0 \| 0 \| 1 \| 0 \| 0 \| 0 //Y-Mirror
		0 \| 1 \| 0 \| 0 \| 1 \| 0 \| 0 \| 0 //X-Mirror
		1 \| 1 \| 0 \| 0 \| 1 \| 0 \| 0 \| 0 //X-Y-Mirror
		0 \| 0 \| 1 \| 0 \| 1 \| 0 \| 0 \| 0 //X-Y Exchange
		1 \| 0 \| 1 \| 0 \| 1 \| 0 \| 0 \| 0 //X-Y Exchange, Y-Mirror
		0 \| 1 \| 1 \| 0 \| 1 \| 0 \| 0 \| 0 //XY exchange
		1 \| 1 \| 1 \| 0 \| 1 \| 0 \| 0 \| 0
		* 7) MY: 1(bottom to top), 0(top to bottom) Row Address Order
		* 6) MX: 1(R to L), 0(L to R) Column Address Order
		* 5) MV: 1(Exchanged), 0(normal) Row/Column exchange
		* 4) ML: 1(bottom to top), 0(top to bottom) Vertical Refresh Order
		* 3) RGB: 1(BGR), 0(RGB) Color Space
		* 2) MH: 1(R to L), 0(L to R) Horizontal Refresh Order
		* 1)
		* 0)
		*
		* MY, MX, MV, ML,RGB, MH, D1, D0
		* 0 \| 0 \| 0 \| 0 \| 1 \| 0 \| 0 \| 0 //normal
		* 1 \| 0 \| 0 \| 0 \| 1 \| 0 \| 0 \| 0 //Y-Mirror
		* 0 \| 1 \| 0 \| 0 \| 1 \| 0 \| 0 \| 0 //X-Mirror
		* 1 \| 1 \| 0 \| 0 \| 1 \| 0 \| 0 \| 0 //X-Y-Mirror
		* 0 \| 0 \| 1 \| 0 \| 1 \| 0 \| 0 \| 0 //X-Y Exchange
		* 1 \| 0 \| 1 \| 0 \| 1 \| 0 \| 0 \| 0 //X-Y Exchange, Y-Mirror
		* 0 \| 1 \| 1 \| 0 \| 1 \| 0 \| 0 \| 0 //XY exchange
		* 1 \| 1 \| 1 \| 0 \| 1 \| 0 \| 0 \| 0
		*/
		static int set_var(struct fbtft_par *par)
		{

drivers/staging/fbtft/fb_ili9320.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -216,9 +216,9 @@ static int set_var(struct fbtft_par *par)
		}

		/*
		Gamma string format:
		VRP0 VRP1 RP0 RP1 KP0 KP1 KP2 KP3 KP4 KP5
		VRN0 VRN1 RN0 RN1 KN0 KN1 KN2 KN3 KN4 KN5
		* Gamma string format:
		* VRP0 VRP1 RP0 RP1 KP0 KP1 KP2 KP3 KP4 KP5
		* VRN0 VRN1 RN0 RN1 KN0 KN1 KN2 KN3 KN4 KN5
		*/
		#define CURVE(num, idx) curves[num * par->gamma.num_values + idx]
		static int set_gamma(struct fbtft_par par, unsigned long curves)

drivers/staging/fbtft/fb_ili9325.c

+40 −40

Original line number	Diff line number	Diff line
		@@ -56,41 +56,41 @@ module_param(vcm, uint, 0);
		MODULE_PARM_DESC(vcm, "Set the internal VcomH voltage");

		/*
		Verify that this configuration is within the Voltage limits

		Display module configuration: Vcc = IOVcc = Vci = 3.3V

		Voltages
		----------
		Vci = 3.3
		Vci1 = Vci * 0.80 = 2.64
		DDVDH = Vci1 * 2 = 5.28
		VCL = -Vci1 = -2.64
		VREG1OUT = Vci * 1.85 = 4.88
		VCOMH = VREG1OUT * 0.735 = 3.59
		VCOM amplitude = VREG1OUT * 0.98 = 4.79
		VGH = Vci * 4 = 13.2
		VGL = -Vci * 4 = -13.2

		Limits
		--------
		Power supplies
		1.65 < IOVcc < 3.30 => 1.65 < 3.3 < 3.30
		2.40 < Vcc < 3.30 => 2.40 < 3.3 < 3.30
		2.50 < Vci < 3.30 => 2.50 < 3.3 < 3.30

		Source/VCOM power supply voltage
		4.50 < DDVDH < 6.0 => 4.50 < 5.28 < 6.0
		-3.0 < VCL < -2.0 => -3.0 < -2.64 < -2.0
		VCI - VCL < 6.0 => 5.94 < 6.0

		Gate driver output voltage
		10 < VGH < 20 => 10 < 13.2 < 20
		-15 < VGL < -5 => -15 < -13.2 < -5
		VGH - VGL < 32 => 26.4 < 32

		VCOM driver output voltage
		VCOMH - VCOML < 6.0 => 4.79 < 6.0
		* Verify that this configuration is within the Voltage limits
		*
		* Display module configuration: Vcc = IOVcc = Vci = 3.3V
		*
		* Voltages
		* ----------
		* Vci = 3.3
		* Vci1 = Vci * 0.80 = 2.64
		* DDVDH = Vci1 * 2 = 5.28
		* VCL = -Vci1 = -2.64
		* VREG1OUT = Vci * 1.85 = 4.88
		* VCOMH = VREG1OUT * 0.735 = 3.59
		* VCOM amplitude = VREG1OUT * 0.98 = 4.79
		* VGH = Vci * 4 = 13.2
		* VGL = -Vci * 4 = -13.2
		*
		* Limits
		* --------
		* Power supplies
		* 1.65 < IOVcc < 3.30 => 1.65 < 3.3 < 3.30
		* 2.40 < Vcc < 3.30 => 2.40 < 3.3 < 3.30
		* 2.50 < Vci < 3.30 => 2.50 < 3.3 < 3.30
		*
		* Source/VCOM power supply voltage
		* 4.50 < DDVDH < 6.0 => 4.50 < 5.28 < 6.0
		* -3.0 < VCL < -2.0 => -3.0 < -2.64 < -2.0
		* VCI - VCL < 6.0 => 5.94 < 6.0
		*
		* Gate driver output voltage
		* 10 < VGH < 20 => 10 < 13.2 < 20
		* -15 < VGL < -5 => -15 < -13.2 < -5
		* VGH - VGL < 32 => 26.4 < 32
		*
		* VCOM driver output voltage
		* VCOMH - VCOML < 6.0 => 4.79 < 6.0
		*/

		static int init_display(struct fbtft_par *par)
		@@ -213,9 +213,9 @@ static int set_var(struct fbtft_par *par)
		}

		/*
		Gamma string format:
		VRP0 VRP1 RP0 RP1 KP0 KP1 KP2 KP3 KP4 KP5
		VRN0 VRN1 RN0 RN1 KN0 KN1 KN2 KN3 KN4 KN5
		* Gamma string format:
		* VRP0 VRP1 RP0 RP1 KP0 KP1 KP2 KP3 KP4 KP5
		* VRN0 VRN1 RN0 RN1 KN0 KN1 KN2 KN3 KN4 KN5
		*/
		#define CURVE(num, idx) curves[num * par->gamma.num_values + idx]
		static int set_gamma(struct fbtft_par par, unsigned long curves)

drivers/staging/fbtft/fb_ili9341.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -116,9 +116,9 @@ static int set_var(struct fbtft_par *par)
		}

		/*
		Gamma string format:
		Positive: Par1 Par2 [...] Par15
		Negative: Par1 Par2 [...] Par15
		* Gamma string format:
		* Positive: Par1 Par2 [...] Par15
		* Negative: Par1 Par2 [...] Par15
		*/
		#define CURVE(num, idx) curves[num * par->gamma.num_values + idx]
		static int set_gamma(struct fbtft_par par, unsigned long curves)