Commit 38eec304 authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: simplify the code to prevent tx/rx blinking restart 



The code for tx/rx blinking is wrapped into a big if clause to prevent
restarting if tx/rx blinking is already running.

Revert the if condition and exit if tx/rx blinking is running. This does
not change the behaviour.

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220911145122.15444-5-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 56e9ef2a

drivers/staging/r8188eu/core/rtw_led.c

+20 −19
Original line number Diff line number Diff line
@@ -284,7 +284,9 @@ void rtw_led_control(struct adapter *padapter, enum LED_CTL_MODE LedAction) 
		break;

	case LED_CTL_TX:

	case LED_CTL_RX:

		if (!pLed->bLedBlinkInProgress) {

		if (pLed->bLedBlinkInProgress)

			return;



		if (pLed->CurrLedState == LED_BLINK_SCAN || IS_LED_WPS_BLINKING(pLed))

			return;

		if (pLed->bLedNoLinkBlinkInProgress) {
@@ -303,7 +305,6 @@ void rtw_led_control(struct adapter *padapter, enum LED_CTL_MODE LedAction) 
		else

			pLed->BlinkingLedState = RTW_LED_ON;

		schedule_delayed_work(&pLed->blink_work, LED_BLINK_FASTER_INTVL);

		}

		break;

	case LED_CTL_START_WPS: /* wait until xinpin finish */

		if (pLed->bLedWPSBlinkInProgress)