Commit 387e69ad authored by Dennis Ranke's avatar Dennis Ranke Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (5373): [PATCH] Hauppauge Nova-T endianess problem on powerpc 



When trying to use a Hauppauge Nova-T Stick on a big-endian architecture
(such as powerpc) no frontend can be attached.
The attached patch fixes this problem by removing two lines in
dib0700_ctrl_rd() that try to correct the endianess on two values that
already are correct:
-       /* think about swapping here */
-       value = le16_to_cpu(value);
-       index = le16_to_cpu(index);
With this simple patch this dvb hardware works great, thanks to anyone
involved for the good work. :)

Signed-off-by: default avatarDennis Ranke <mail@exoticorn.de>
Signed-off-by: default avatarPatrick Boettcher <pb@linuxtv.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
parent ddc9ece8

drivers/media/dvb/dvb-usb/dib0700_core.c

+0 −4
Original line number Diff line number Diff line
@@ -56,10 +56,6 @@ static int dib0700_ctrl_rd(struct dvb_usb_device *d, u8 *tx, u8 txlen, u8 *rx, u 
	if (txlen > 3)

		index |= tx[3];



	/* think about swapping here */

	value = le16_to_cpu(value);

	index = le16_to_cpu(index);



	status = usb_control_msg(d->udev, usb_rcvctrlpipe(d->udev,0), tx[0],

			USB_TYPE_VENDOR | USB_DIR_IN, value, index, rx, rxlen,

			USB_CTRL_GET_TIMEOUT);

drivers/media/dvb/dvb-usb/dib0700_devices.c

+1 −1
Original line number Diff line number Diff line
@@ -287,7 +287,7 @@ MODULE_DEVICE_TABLE(usb, dib0700_usb_id_table); 
#define DIB0700_DEFAULT_DEVICE_PROPERTIES \

	.caps              = DVB_USB_IS_AN_I2C_ADAPTER, \

	.usb_ctrl          = DEVICE_SPECIFIC, \

	.firmware          = "dvb-usb-dib0700-02-rc1.fw", \

	.firmware          = "dvb-usb-dib0700-01.fw", \

	.download_firmware = dib0700_download_firmware, \

	.no_reconnect      = 1, \

	.size_of_priv      = sizeof(struct dib0700_state), \