Commit 37feaaf5 authored by Alexander Aring's avatar Alexander Aring Committed by Stefan Schmidt
Browse files

net: ieee802154: fix nl802154 del llsec key 



This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_KEY is
not set by the user. If this is the case nl802154 will return -EINVAL.

Reported-by: default avatar <syzbot+ac5c11d2959a8b3c4806@syzkaller.appspotmail.com>
Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
Link: https://lore.kernel.org/r/20210221174321.14210-1-aahringo@redhat.com


Signed-off-by: default avatarStefan Schmidt <stefan@datenfreihafen.org>
parent cdd38c5f

net/ieee802154/nl802154.c

+2 −1
Original line number Diff line number Diff line
@@ -1592,7 +1592,8 @@ static int nl802154_del_llsec_key(struct sk_buff *skb, struct genl_info *info) 
	struct nlattr *attrs[NL802154_KEY_ATTR_MAX + 1];

	struct ieee802154_llsec_key_id id;



	if (nla_parse_nested_deprecated(attrs, NL802154_KEY_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_KEY], nl802154_key_policy, info->extack))

	if (!info->attrs[NL802154_ATTR_SEC_KEY] ||

	    nla_parse_nested_deprecated(attrs, NL802154_KEY_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_KEY], nl802154_key_policy, info->extack))

		return -EINVAL;



	if (ieee802154_llsec_parse_key_id(attrs[NL802154_KEY_ATTR_ID], &id) < 0)