Commit 369e1b69 authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Greg Kroah-Hartman
Browse files

staging: ks7010: return on failure 



On failure we were jumping to error_out0 where we were trying
sdio_release_host() but at this point of execution we still have not
done sdio_claim_host() and as a result host->claimed can still be 0.
And if host->claimed is 0 then WARN_ON(!host->claimed) will give
a warning.
Moreover, if it is still not claimed then mmc_host->claim_cnt will be 0
and mmc_release_host() will do "if (--host->claim_cnt)" and thus the
condition will become true.
Lets just return the value on allocation failure instead of trying to
release the host before claiming it.

Signed-off-by: default avatarSudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 98a3c4d7

drivers/staging/ks7010/ks7010_sdio.c

+2 −4
Original line number Diff line number Diff line
@@ -776,10 +776,8 @@ static int ks7010_upload_firmware(struct ks_wlan_private *priv, 


	/* buffer allocate */

	rom_buf = kmalloc(ROM_BUFF_SIZE, GFP_KERNEL);

	if (!rom_buf) {

		rc = 3;

		goto error_out0;

	}

	if (!rom_buf)

		return 3;



	sdio_claim_host(card->func);