Commit 35df4b75 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Linus Walleij
Browse files

pinctrl: stmfx: Improve error message in .remove()'s error path 



The driver core has no handling for errors returned by the .remove()
callback. The only action on error is a dev_warn() with generic error
message that the returned value is returned.

Replace it by a more specific and useful message. Then returning zero is
the right thing to do, the only effect is to suppress the core's
warning.

This prepares the driver for the conversion to .remove_new().

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231009083856.222030-2-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent b1191940

drivers/pinctrl/pinctrl-stmfx.c

+10 −4
Original line number Diff line number Diff line
@@ -737,11 +737,17 @@ static int stmfx_pinctrl_probe(struct platform_device *pdev) 
static int stmfx_pinctrl_remove(struct platform_device *pdev)

{

	struct stmfx *stmfx = dev_get_drvdata(pdev->dev.parent);

	int ret;



	return stmfx_function_disable(stmfx,

	ret = stmfx_function_disable(stmfx,

				     STMFX_FUNC_GPIO |

				     STMFX_FUNC_ALTGPIO_LOW |

				     STMFX_FUNC_ALTGPIO_HIGH);

	if (ret)

		dev_err(&pdev->dev, "Failed to disable pins (%pe)\n",

			ERR_PTR(ret));



	return 0;

}



#ifdef CONFIG_PM_SLEEP