Commit 3515279e authored by Dominic Braun's avatar Dominic Braun Committed by Greg Kroah-Hartman
Browse files

staging: vc04_services: Remove VCHIQ_GET_CONFIG_T typedef 



Typedefing structs is not encouraged in the kernel.

Signed-off-by: default avatarDominic Braun <inf.braun@fau.de>
Signed-off-by: default avatarTobias Büttner <tobias.buettner@fau.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 392342b7

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

+2 −2
Original line number Diff line number Diff line
@@ -1407,7 +1407,7 @@ vchiq_ioctl(struct file *file, unsigned int cmd, unsigned long arg) 
	} break;



	case VCHIQ_IOC_GET_CONFIG: {

		VCHIQ_GET_CONFIG_T args;

		struct vchiq_get_config args;

		struct vchiq_config config;



		if (copy_from_user(&args, (const void __user *)arg,
@@ -1911,7 +1911,7 @@ vchiq_compat_ioctl_get_config(struct file *file, 
			      unsigned int cmd,

			      unsigned long arg)

{

	VCHIQ_GET_CONFIG_T __user *args;

	struct vchiq_get_config __user *args;

	struct vchiq_get_config32 args32;



	args = compat_alloc_user_space(sizeof(*args));

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h

+3 −3
Original line number Diff line number Diff line
@@ -83,10 +83,10 @@ struct vchiq_dequeue_message { 
	void *buf;

};



typedef struct {

struct vchiq_get_config {

	unsigned int config_size;

	struct vchiq_config __user *pconfig;

} VCHIQ_GET_CONFIG_T;

};



typedef struct {

	unsigned int handle;
@@ -116,7 +116,7 @@ struct vchiq_dump_mem { 
	_IOWR(VCHIQ_IOC_MAGIC, 8, struct vchiq_dequeue_message)

#define VCHIQ_IOC_GET_CLIENT_ID        _IO(VCHIQ_IOC_MAGIC,   9)

#define VCHIQ_IOC_GET_CONFIG \

	_IOWR(VCHIQ_IOC_MAGIC, 10, VCHIQ_GET_CONFIG_T)

	_IOWR(VCHIQ_IOC_MAGIC, 10, struct vchiq_get_config)

#define VCHIQ_IOC_CLOSE_SERVICE        _IO(VCHIQ_IOC_MAGIC,   11)

#define VCHIQ_IOC_USE_SERVICE          _IO(VCHIQ_IOC_MAGIC,   12)

#define VCHIQ_IOC_RELEASE_SERVICE      _IO(VCHIQ_IOC_MAGIC,   13)