Commit 340a60e3 authored by Benjamin Gray's avatar Benjamin Gray Committed by Michael Ellerman
Browse files

powerpc: Explicitly reverse bytes when checking for byte reversal 



Sparse reports an invalid endian cast here. The code is written for
big endian platforms, so le32_to_cpu() acts as a byte reversal.

This file is checked by sparse on a little endian build though, so
replace the reverse function with the dedicated swab32() function to
better express the intent of the code.

Signed-off-by: default avatarBenjamin Gray <bgray@linux.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20231011053711.93427-4-bgray@linux.ibm.com
parent ff7a60ab

arch/powerpc/sysdev/mpic.c

+1 −1
Original line number Diff line number Diff line
@@ -355,7 +355,7 @@ static void __init mpic_test_broken_ipi(struct mpic *mpic) 
	mpic_write(mpic->gregs, MPIC_INFO(GREG_IPI_VECTOR_PRI_0), MPIC_VECPRI_MASK);

	r = mpic_read(mpic->gregs, MPIC_INFO(GREG_IPI_VECTOR_PRI_0));



	if (r == le32_to_cpu(MPIC_VECPRI_MASK)) {

	if (r == swab32(MPIC_VECPRI_MASK)) {

		printk(KERN_INFO "mpic: Detected reversed IPI registers\n");

		mpic->flags |= MPIC_BROKEN_IPI;

	}