Commit 32417d78 authored by Alex Dewar's avatar Alex Dewar Committed by Martin K. Petersen
Browse files

scsi: esas2r: Remove unnecessary casts 

In a number of places in esas2r_ioctl.c, the void* returned from
pci_alloc_consistent() is cast unnecessarily. Remove casts.

Issue identified with Coccinelle.

Link: https://lore.kernel.org/r/20200820181411.866057-1-alex.dewar90@gmail.com


Signed-off-by: default avatarAlex Dewar <alex.dewar90@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 44f4daf8

drivers/scsi/esas2r/esas2r_ioctl.c

+13 −15
Original line number Diff line number Diff line
@@ -1548,10 +1548,9 @@ static int allocate_fw_buffers(struct esas2r_adapter *a, u32 length) 


	a->firmware.orig_len = length;



	a->firmware.data = (u8 *)dma_alloc_coherent(&a->pcid->dev,

	a->firmware.data = dma_alloc_coherent(&a->pcid->dev,

					      (size_t)length,

						    (dma_addr_t *)&a->firmware.

						    phys,

					      (dma_addr_t *)&a->firmware.phys,

					      GFP_KERNEL);



	if (!a->firmware.data) {
@@ -1895,7 +1894,7 @@ int esas2r_write_vda(struct esas2r_adapter *a, const char *buf, long off, 


	if (!a->vda_buffer) {

		dma_addr_t dma_addr;

		a->vda_buffer = (u8 *)dma_alloc_coherent(&a->pcid->dev,

		a->vda_buffer = dma_alloc_coherent(&a->pcid->dev,

						   (size_t)

						   VDA_MAX_BUFFER_SIZE,

						   &dma_addr,
@@ -2064,8 +2063,7 @@ int esas2r_write_fs(struct esas2r_adapter *a, const char *buf, long off, 
re_allocate_buffer:

			a->fs_api_buffer_size = length;



			a->fs_api_buffer = (u8 *)dma_alloc_coherent(

				&a->pcid->dev,

			a->fs_api_buffer = dma_alloc_coherent(&a->pcid->dev,

							      (size_t)a->fs_api_buffer_size,

							      (dma_addr_t *)&a->ppfs_api_buffer,

							      GFP_KERNEL);