Commit 313b5681 authored by Dominic Braun's avatar Dominic Braun Committed by Greg Kroah-Hartman
Browse files

staging: vc04_services: Remove PAGELIST_T typedef 



Typedefing structs is not encouraged in the kernel.

Signed-off-by: default avatarDominic Braun <inf.braun@fau.de>
Signed-off-by: default avatarTobias Büttner <tobias.buettner@fau.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4eef62d6

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c

+5 −5
Original line number Diff line number Diff line
@@ -64,7 +64,7 @@ struct vchiq_2835_state { 
};



struct vchiq_pagelist_info {

	PAGELIST_T *pagelist;

	struct pagelist *pagelist;

	size_t pagelist_buffer_size;

	dma_addr_t dma_addr;

	enum dma_data_direction dma_dir;
@@ -383,7 +383,7 @@ cleanup_pagelistinfo(struct vchiq_pagelist_info *pagelistinfo) 
static struct vchiq_pagelist_info *

create_pagelist(char __user *buf, size_t count, unsigned short type)

{

	PAGELIST_T *pagelist;

	struct pagelist *pagelist;

	struct vchiq_pagelist_info *pagelistinfo;

	struct page **pages;

	u32 *addrs;
@@ -397,7 +397,7 @@ create_pagelist(char __user *buf, size_t count, unsigned short type) 
	offset = ((unsigned int)(unsigned long)buf & (PAGE_SIZE - 1));

	num_pages = DIV_ROUND_UP(count + offset, PAGE_SIZE);



	pagelist_size = sizeof(PAGELIST_T) +

	pagelist_size = sizeof(struct pagelist) +

			(num_pages * sizeof(u32)) +

			(num_pages * sizeof(pages[0]) +

			(num_pages * sizeof(struct scatterlist))) +
@@ -565,7 +565,7 @@ static void 
free_pagelist(struct vchiq_pagelist_info *pagelistinfo,

	      int actual)

{

	PAGELIST_T *pagelist   = pagelistinfo->pagelist;

	struct pagelist *pagelist = pagelistinfo->pagelist;

	struct page **pages = pagelistinfo->pages;

	unsigned int num_pages = pagelistinfo->num_pages;

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_pagelist.h

+2 −2
Original line number Diff line number Diff line
@@ -38,7 +38,7 @@ 
#define PAGELIST_READ 1

#define PAGELIST_READ_WITH_FRAGMENTS 2



typedef struct pagelist_struct {

struct pagelist {

	u32 length;

	u16 type;

	u16 offset;
@@ -46,6 +46,6 @@ typedef struct pagelist_struct { 
			 * of following pages at consecutive

			 * addresses.

			 */

} PAGELIST_T;

};



#endif /* VCHIQ_PAGELIST_H */