Commit 3073acd6 authored by Julia Lawall's avatar Julia Lawall Committed by Greg Kroah-Hartman
Browse files

staging: msm/lcdc.c: Convert IS_ERR result to PTR_ERR 

This code elsewhere returns a negative constant to an indicate an error,
while IS_ERR returns the result of a >= operation.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression x;
@@

 if (...) { ...
- return IS_ERR(x);
+ return PTR_ERR(x);
}
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Acked-by: default avatarDavid Brown <davidb@codeaurora.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent da9fcb72

drivers/staging/msm/lcdc.c

+2 −2
Original line number Diff line number Diff line
@@ -224,12 +224,12 @@ static int __init lcdc_driver_init(void) 
	mdp_lcdc_pclk_clk = clk_get(NULL, "mdp_lcdc_pclk_clk");

	if (IS_ERR(mdp_lcdc_pclk_clk)) {

		printk(KERN_ERR "error: can't get mdp_lcdc_pclk_clk!\n");

		return IS_ERR(mdp_lcdc_pclk_clk);

		return PTR_ERR(mdp_lcdc_pclk_clk);

	}

	mdp_lcdc_pad_pclk_clk = clk_get(NULL, "mdp_lcdc_pad_pclk_clk");

	if (IS_ERR(mdp_lcdc_pad_pclk_clk)) {

		printk(KERN_ERR "error: can't get mdp_lcdc_pad_pclk_clk!\n");

		return IS_ERR(mdp_lcdc_pad_pclk_clk);

		return PTR_ERR(mdp_lcdc_pad_pclk_clk);

	}

//	pm_qos_add_requirement(PM_QOS_SYSTEM_BUS_FREQ , "lcdc",

//				PM_QOS_DEFAULT_VALUE);