Commit 2fd52124 authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Jonathan Cameron
Browse files

iio: as3935: Use sysfs_emit() 



sysfs_emit() is preferred over raw s*printf() for sysfs attributes since it
knows about the sysfs buffer specifics and has some built-in checks for
size and alignment.

Use sysfs_emit() to format the custom `noise_level_tripped` device
attribute of the as3935 driver.

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20211216185217.1054495-6-lars@metafoo.de


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 48788715

drivers/iio/proximity/as3935.c

+2 −2
Original line number Diff line number Diff line
@@ -122,7 +122,7 @@ static ssize_t as3935_sensor_sensitivity_show(struct device *dev, 
		return ret;

	val = (val & AS3935_AFE_MASK) >> 1;



	return sprintf(buf, "%d\n", val);

	return sysfs_emit(buf, "%d\n", val);

}



static ssize_t as3935_sensor_sensitivity_store(struct device *dev,
@@ -153,7 +153,7 @@ static ssize_t as3935_noise_level_tripped_show(struct device *dev, 
	int ret;



	mutex_lock(&st->lock);

	ret = sprintf(buf, "%d\n", !time_after(jiffies, st->noise_tripped + HZ));

	ret = sysfs_emit(buf, "%d\n", !time_after(jiffies, st->noise_tripped + HZ));

	mutex_unlock(&st->lock);



	return ret;