Commit 2fbffee0 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: remove thisboard macro in the pcmda12 driver 



The 'thisboard' macro depends on having a local variable with
a magic name. The CodingStyle document suggests not doing this
to avoid confusion. Remove the macro and use the comedi_board()
inline helper to get the dev->board_ptr information.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 57bbeb3b

drivers/staging/comedi/drivers/pcmda12.c

+2 −10
Original line number Diff line number Diff line
@@ -80,11 +80,6 @@ static const struct comedi_lrange pcmda12_ranges = { 
	 }

};



/*

 * Useful for shorthand access to the particular board structure

 */

#define thisboard ((const struct pcmda12_board *)dev->board_ptr)



struct pcmda12_private {



	unsigned int ao_readback[CHANS];
@@ -167,6 +162,7 @@ static int ao_rinsn(struct comedi_device *dev, struct comedi_subdevice *s, 
static int pcmda12_attach(struct comedi_device *dev,

			  struct comedi_devconfig *it)

{

	const struct pcmda12_board *board = comedi_board(dev);

	struct comedi_subdevice *s;

	unsigned long iobase;
@@ -181,11 +177,7 @@ static int pcmda12_attach(struct comedi_device *dev, 
	}

	dev->iobase = iobase;



/*

 * Initialize dev->board_name.  Note that we can use the "thisboard"

 * macro now, since we just initialized it in the last line.

 */

	dev->board_name = thisboard->name;

	dev->board_name = board->name;



/*

 * Allocate the private structure area.  alloc_private() is a