Commit 2fbf6d61 authored by Haneen Mohammed's avatar Haneen Mohammed Committed by Greg Kroah-Hartman
Browse files

Staging: vt6655: Add check dma_mapping_error 



This patch checks for dma_mapping_error() after using dma_map_single.
If the dma map fails we release skb buff allocated by dev_alloc_skb() to
avoid possible causes of resource leak.

Signed-off-by: default avatarHaneen Mohammed <hamohammed.sa@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 27f31cf9

drivers/staging/vt6655/device_main.c

+5 −0
Original line number Diff line number Diff line
@@ -742,6 +742,11 @@ static bool device_alloc_rx_buf(struct vnt_private *priv, 
		dma_map_single(&priv->pcid->dev,

			       skb_put(rd_info->skb, skb_tailroom(rd_info->skb)),

			       priv->rx_buf_sz, DMA_FROM_DEVICE);

	if (dma_mapping_error(&priv->pcid->dev, rd_info->skb_dma)) {

		dev_kfree_skb(rd_info->skb);

		rd_info->skb = NULL;

		return false;

	}



	*((unsigned int *)&rd->rd0) = 0; /* FIX cast */