Commit 2f33a397 authored by Dan Carpenter's avatar Dan Carpenter Committed by Alex Deucher
Browse files

drm/amdgpu: debugfs: fix NULL dereference in ta_if_invoke_debugfs_write() 



If the kzalloc() fails then this code will crash.  Return -ENOMEM instead.

Fixes: e50d9ba0 ("drm/amdgpu: Add debugfs TA load/unload/invoke support")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent a52ad5b6

drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c

+1 −1
Original line number Diff line number Diff line
@@ -254,7 +254,7 @@ static ssize_t ta_if_invoke_debugfs_write(struct file *fp, const char *buf, size 


	shared_buf = kzalloc(shared_buf_len, GFP_KERNEL);

	if (!shared_buf)

		ret = -ENOMEM;

		return -ENOMEM;

	if (copy_from_user((void *)shared_buf, &buf[copy_pos], shared_buf_len)) {

		ret = -EFAULT;

		goto err_free_shared_buf;