Commit 2f123cbc authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

Staging: xgifb: fix bitwise vs logical bug 



This is a static checker fix and not something I can test.  The intent
of the code here is to set some bit flags.  For a logical OR the ">> 1"
shift wouldn't make a difference.  So it should be using a bitwise OR.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarPeter Huewe <peterhuewe@gmx.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 95605332

drivers/staging/xgifb/vb_init.c

+1 −1
Original line number Diff line number Diff line
@@ -1269,7 +1269,7 @@ static unsigned char GetXG27FPBits(struct vb_device_info *pVBInfo) 
	if (temp <= 2)

		temp &= 0x03;

	else

		temp = ((temp & 0x04) >> 1) || ((~temp) & 0x01);

		temp = ((temp & 0x04) >> 1) | ((~temp) & 0x01);



	xgifb_reg_set(pVBInfo->P3d4, 0x4A, CR4A);