Commit 2cec8029 authored by Ben Hutchings's avatar Ben Hutchings Committed by James Bottomley
Browse files

[SCSI] qla1280: Drop host_lock while requesting firmware 



request_firmware() may sleep and it appears to be safe to release the
spinlock here.

Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
Cc: stable@kernel.org
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent 7c56533c

drivers/scsi/qla1280.c

+4 −0
Original line number Diff line number Diff line
@@ -1640,8 +1640,10 @@ qla1280_load_firmware_pio(struct scsi_qla_host *ha) 
	uint16_t mb[MAILBOX_REGISTER_COUNT], i;

	int err;



	spin_unlock_irq(ha->host->host_lock);

	err = request_firmware(&fw, ql1280_board_tbl[ha->devnum].fwname,

			       &ha->pdev->dev);

	spin_lock_irq(ha->host->host_lock);

	if (err) {

		printk(KERN_ERR "Failed to load image \"%s\" err %d\n",

		       ql1280_board_tbl[ha->devnum].fwname, err);
@@ -1699,8 +1701,10 @@ qla1280_load_firmware_dma(struct scsi_qla_host *ha) 
		return -ENOMEM;

#endif



	spin_unlock_irq(ha->host->host_lock);

	err = request_firmware(&fw, ql1280_board_tbl[ha->devnum].fwname,

			       &ha->pdev->dev);

	spin_lock_irq(ha->host->host_lock);

	if (err) {

		printk(KERN_ERR "Failed to load image \"%s\" err %d\n",

		       ql1280_board_tbl[ha->devnum].fwname, err);