Commit 2c4ce504 authored by Cai Huoqing's avatar Cai Huoqing Committed by Jonathan Cameron
Browse files

iio: adc: ina2xx: Avoid double reference counting from get_task_struct/put_task_struct() 



kthread_run() and kthread_stop() already do reference
counting of the task, so remove get_task_struct/put_task_struct()
to avoid double reference counting.

Signed-off-by: default avatarCai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20211021124254.3247-2-caihuoqing@baidu.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 4bdc3e96

drivers/iio/adc/ina2xx-adc.c

+0 −2
Original line number Diff line number Diff line
@@ -849,7 +849,6 @@ static int ina2xx_buffer_enable(struct iio_dev *indio_dev) 
	if (IS_ERR(task))

		return PTR_ERR(task);



	get_task_struct(task);

	chip->task = task;



	return 0;
@@ -861,7 +860,6 @@ static int ina2xx_buffer_disable(struct iio_dev *indio_dev) 


	if (chip->task) {

		kthread_stop(chip->task);

		put_task_struct(chip->task);

		chip->task = NULL;

	}