Commit 2c21832b authored by Jiri Slaby's avatar Jiri Slaby Committed by Greg Kroah-Hartman
Browse files

mxser: cleanup mxser_change_speed 



* use UART macros instead of magic constants
* let the default case reuse already existing code (CS5 case)

Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20210618061516.662-38-jslaby@suse.cz


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d811b26b

drivers/tty/mxser.c

+7 −8
Original line number Diff line number Diff line
@@ -657,24 +657,23 @@ static void mxser_change_speed(struct tty_struct *tty) 


	/* byte size and parity */

	switch (cflag & CSIZE) {

	default:

	case CS5:

		cval = 0x00;

		cval = UART_LCR_WLEN5;

		break;

	case CS6:

		cval = 0x01;

		cval = UART_LCR_WLEN6;

		break;

	case CS7:

		cval = 0x02;

		cval = UART_LCR_WLEN7;

		break;

	case CS8:

		cval = 0x03;

		cval = UART_LCR_WLEN8;

		break;

	default:

		cval = 0x00;

		break;		/* too keep GCC shut... */

	}



	if (cflag & CSTOPB)

		cval |= 0x04;

		cval |= UART_LCR_STOP;

	if (cflag & PARENB)

		cval |= UART_LCR_PARITY;

	if (!(cflag & PARODD))