Commit 2b89b73a authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Mauro Carvalho Chehab
Browse files

media: gspca: sq930x: use GFP_KERNEL in sd_dq_callback() 



The context in which sd_dq_callback() is non atomic, there is even
msleep() at the end of the function. There is no need to use GFP_ATOMIC
here - use GFP_KERNEL instead.

Cc: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent fc8af4fb

drivers/media/usb/gspca/sq930x.c

+1 −1
Original line number Diff line number Diff line
@@ -1044,7 +1044,7 @@ static void sd_dq_callback(struct gspca_dev *gspca_dev) 
			v4l2_ctrl_g_ctrl(sd->gain));



	gspca_dev->cam.bulk_nurbs = 1;

	ret = usb_submit_urb(gspca_dev->urb[0], GFP_ATOMIC);

	ret = usb_submit_urb(gspca_dev->urb[0], GFP_KERNEL);

	if (ret < 0)

		pr_err("sd_dq_callback() err %d\n", ret);