Commit 2b541cf9 authored by Koby Elbaz's avatar Koby Elbaz Committed by Oded Gabbay
Browse files

accel/habanalabs: print return code when process termination fails 



As part of driver teardown, we attempt to kill all user processes.
It shouldn't fail, but if it does we want to print the error code that
the kapi returned to us.

Signed-off-by: default avatarKoby Elbaz <kelbaz@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent bffd2f16

drivers/accel/habanalabs/common/device.c

+4 −3
Original line number Diff line number Diff line
@@ -1352,7 +1352,8 @@ static int device_kill_open_processes(struct hl_device *hdev, u32 timeout, bool 
			 * we don't need to kill it.

			 */

			dev_dbg(hdev->dev,

				"Can't get task struct for user process, assuming process was killed from outside the driver\n");

				"Can't get task struct for user process %d, assuming process was killed from outside the driver\n",

				pid_nr(hpriv->taskpid));

		}

	}
@@ -2438,14 +2439,14 @@ void hl_device_fini(struct hl_device *hdev) 
	hdev->process_kill_trial_cnt = 0;

	rc = device_kill_open_processes(hdev, HL_WAIT_PROCESS_KILL_ON_DEVICE_FINI, false);

	if (rc) {

		dev_crit(hdev->dev, "Failed to kill all open processes\n");

		dev_crit(hdev->dev, "Failed to kill all open processes (%d)\n", rc);

		device_disable_open_processes(hdev, false);

	}



	hdev->process_kill_trial_cnt = 0;

	rc = device_kill_open_processes(hdev, 0, true);

	if (rc) {

		dev_crit(hdev->dev, "Failed to kill all control device open processes\n");

		dev_crit(hdev->dev, "Failed to kill all control device open processes (%d)\n", rc);

		device_disable_open_processes(hdev, true);

	}