Commit 269da10b authored by Aiman Najjar's avatar Aiman Najjar Committed by Greg Kroah-Hartman
Browse files

staging: rtl8712: fix multiline derefernce warnings 



This patch fixes remaining checkpatch warnings
in rtl871x_xmit.c:

WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->PrivacyKeyIndex'
636: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:636:
+					      (u8)psecuritypriv->
+					      PrivacyKeyIndex);

WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->XGrpKeyid'
643: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:643:
+						   (u8)psecuritypriv->
+						   XGrpKeyid);

WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->XGrpKeyid'
652: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:652:
+						   (u8)psecuritypriv->
+						   XGrpKeyid);

Signed-off-by: default avatarAiman Najjar <aiman.najjar@hurranet.com>
Reviewed-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/98805a72b92e9bbf933e05b827d27944663b7bc1.1585508171.git.aiman.najjar@hurranet.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2aaeaaff

drivers/staging/rtl8712/rtl871x_xmit.c

+4 −7
Original line number Diff line number Diff line
@@ -586,7 +586,7 @@ sint r8712_xmitframe_coalesce(struct _adapter *padapter, _pkt *pkt, 
	addr_t addr;

	u8 *pframe, *mem_start, *ptxdesc;

	struct sta_info		*psta;

	struct security_priv	*psecuritypriv = &padapter->securitypriv;

	struct security_priv	*psecpriv = &padapter->securitypriv;

	struct mlme_priv	*pmlmepriv = &padapter->mlmepriv;

	struct xmit_priv	*pxmitpriv = &padapter->xmitpriv;

	struct pkt_attrib	*pattrib = &pxmitframe->attrib;
@@ -629,15 +629,13 @@ sint r8712_xmitframe_coalesce(struct _adapter *padapter, _pkt *pkt, 
				case _WEP40_:

				case _WEP104_:

					WEP_IV(pattrib->iv, psta->txpn,

					       (u8)psecuritypriv->

					       PrivacyKeyIndex);

					       (u8)psecpriv->PrivacyKeyIndex);

					break;

				case _TKIP_:

					if (bmcst)

						TKIP_IV(pattrib->iv,

						    psta->txpn,

						    (u8)psecuritypriv->

						    XGrpKeyid);

						    (u8)psecpriv->XGrpKeyid);

					else

						TKIP_IV(pattrib->iv, psta->txpn,

							0);
@@ -645,8 +643,7 @@ sint r8712_xmitframe_coalesce(struct _adapter *padapter, _pkt *pkt, 
				case _AES_:

					if (bmcst)

						AES_IV(pattrib->iv, psta->txpn,

						    (u8)psecuritypriv->

						    XGrpKeyid);

						    (u8)psecpriv->XGrpKeyid);

					else

						AES_IV(pattrib->iv, psta->txpn,

						       0);