Commit 2636d005 authored May 21, 2018 by Alexandru Ardelean Committed by Jonathan Cameron May 22, 2018

iio: amplifiers: ad8366: move channel init before iio_device_register()

Otherwise a race condition can occur, where userspace can start operations
before the channels have been properly initialized.

Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

parent 55dda0ab

drivers/iio/amplifiers/ad8366.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -161,12 +161,14 @@ static int ad8366_probe(struct spi_device *spi)
		indio_dev->channels = ad8366_channels;
		indio_dev->num_channels = ARRAY_SIZE(ad8366_channels);

		ret = ad8366_write(indio_dev, 0 , 0);
		if (ret < 0)
		goto error_disable_reg;

		ret = iio_device_register(indio_dev);
		if (ret)
		goto error_disable_reg;

		ad8366_write(indio_dev, 0, 0);

		return 0;

		error_disable_reg: